Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add submodule with relative URL to .gitmodules #5

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

neersighted
Copy link
Member

Successor to #4, which was not entirely correct and could not be amended as it was made off the master branch.

Introduce a relative URL submodule as a test fixture based on a branch on this same repository with no history.

Co-authored by @evanrittenhouse

@neersighted neersighted merged commit e9b5b32 into main Oct 1, 2022
@neersighted neersighted deleted the add_relative_submodule branch October 1, 2022 15:36
@evanrittenhouse
Copy link
Contributor

evanrittenhouse commented Oct 8, 2022

@neersighted I believe standalone_branch needs a git repo to count as a submodule, right? Currently it just has a README.

On a related note, is there a reason we don't want to just add another submodule to main similar to sample_namespace_packages?

This is in reference to python-poetry/poetry#6499.

@neersighted
Copy link
Member Author

I'm not sure what you mean -- standalone_branch is a branch on this repo with disparate history and a README, indeed. However, it shares the same .git folder as this repo as it is just a branch on this repo referenced as a submodule.

Do you mean why we don't use a stand-alone repo as the test submodule? There's not a lot of point in doing that when we can just be self-contained and reference ourselves/I don't want to create another test fixture on the python-poetry org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants