Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pip-based installer #9392

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented May 6, 2024

following through on #8987

remaining uses of pip in poetry

  • installation of the managed package, when that package has a build script: here
  • uninstalling packages: here

desirable to remove both of these in the long run...

@dimbleby dimbleby mentioned this pull request May 27, 2024
@Secrus Secrus enabled auto-merge (squash) July 21, 2024 18:09
@Secrus Secrus merged commit 2e3a421 into python-poetry:main Jul 21, 2024
76 checks passed
@dimbleby dimbleby deleted the remove-pip-installer branch July 21, 2024 18:17
@edmorley
Copy link

edmorley commented Aug 11, 2024

remaining uses of pip in poetry

* installation of the managed package, when that package has a build script: [here](https://github.com/python-poetry/poetry/blob/43dd8cce4f04120ee698609fa0a0a66063e80dcd/src/poetry/masonry/builders/editable.py#L102)

* uninstalling packages: [here](https://github.com/python-poetry/poetry/blob/43dd8cce4f04120ee698609fa0a0a66063e80dcd/src/poetry/installation/executor.py#L592)

desirable to remove both of these in the long run...

Hi! Are there issues filed for removing these two usages of invoking pip? I tried searching but there are 200+ results for "pip" (and filtering further was a bit hit or miss):
https://github.com/python-poetry/poetry/issues?q=is%3Aissue+is%3Aopen+pip

@dimbleby
Copy link
Contributor Author

dimbleby commented Aug 11, 2024

If you would like to contribute please just go ahead, no need for ceremony.

Some hints here

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants