Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow specifying local version label #9064

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

abn
Copy link
Member

@abn abn commented Feb 29, 2024

Resolves: #1208

@abn abn added the area/cli Related to the command line label Feb 29, 2024
@abn abn requested a review from a team February 29, 2024 01:13
@abn abn force-pushed the build-local-version branch from 8320adf to 4534c47 Compare February 29, 2024 01:42
Secrus
Secrus previously requested changes Feb 29, 2024
Copy link
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one issue, otherwise LGTM

src/poetry/console/commands/build.py Outdated Show resolved Hide resolved
@abn abn force-pushed the build-local-version branch from 15a788b to 3f8104b Compare February 29, 2024 12:28
@abn abn requested a review from Secrus February 29, 2024 12:29
@abn abn merged commit 104dc1c into python-poetry:main Feb 29, 2024
36 checks passed
@abn abn deleted the build-local-version branch February 29, 2024 12:38
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to append build number to version identifier at build time
2 participants