Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply requests best practices #8558

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Apply requests best practices #8558

merged 2 commits into from
Oct 20, 2023

Conversation

jakob-keller
Copy link
Contributor

@jakob-keller jakob-keller commented Oct 19, 2023

Pull Request Check List

Resolves: n/a

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR does not change behaviour in any way, but streamlines the use of the requests library by:

  • avoiding use of deprecated requests.session()
  • use requests.Session as context

@radoering radoering merged commit c41e213 into python-poetry:master Oct 20, 2023
19 checks passed
@jakob-keller jakob-keller deleted the requests-session branch October 20, 2023 14:11
MrGreenTea pushed a commit to MrGreenTea/poetry that referenced this pull request Dec 18, 2023
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants