Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solver: ignore dependencies that are only relevant for inactive extras #8399

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

radoering
Copy link
Member

Pull Request Check List

Resolves: #8380

Requires: python-poetry/poetry-core#636

  • Added tests for changed code.
  • Updated documentation for changed code.

Secrus
Secrus previously approved these changes Sep 11, 2023
Copy link
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure if you want to merge it now or wait for next release to handle dependency on poetry-core

poetry.lock Outdated Show resolved Hide resolved
@radoering radoering force-pushed the ignore-inactive-extras branch from 19804a9 to a979383 Compare November 1, 2023 16:08
@radoering radoering merged commit 930ac5a into python-poetry:master Nov 3, 2023
19 checks passed
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
@radoering radoering deleted the ignore-inactive-extras branch November 24, 2024 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry install --sync and poetry update install different packages based on transitive extras
2 participants