feature(virtualenv): add 'system-site-packages' option #3711
Conversation
|
This is just a rebase to |
vlad0337187
force-pushed
the
1393-system-site-packages-3
branch
from
9255958
to
3c1f245
Compare
vlad0337187
force-pushed
the
1393-system-site-packages-3
branch
from
3c1f245
to
6c44e27
Compare
|
Great work, this commit will have a huge effect on my SSD capacity 😄 |
|
@abn , could you review it please when you'll have some free time ? |
There was a problem hiding this comment.
Thank you @vlad0337187. The change looks good to me. I have added one comment to help with future code maintanence.
| @@ -159,7 +159,7 @@ def test_activate_activates_non_existing_virtualenv_no_envs_file( | |||
| m.assert_called_with( | |||
| Path(tmp_dir) / "{}-py3.7".format(venv_name), | |||
| executable="python3.7", | |||
| flags={"always-copy": False}, | |||
| flags={"always-copy": False, "system-site-packages": False}, | |||
There was a problem hiding this comment.
Would be great to move this to a fixture so future additions or changes to defaults would be cleaner.
|
This also could be useful on Apple Silicon, where there are no NumPy wheels yet but most systems (homebrew, conda-forge) provide binaries for NumPy. |
|
Thank you all!!! This will be very useful, I've been waiting on it ;) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #issue-number-here
Closes: #1982
Resolves: #1393