Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resume download by appending to existing file #3454

Closed
wants to merge 3 commits into from

Conversation

CTimmerman
Copy link

Pull Request Check List

Resolves: #3453

  • Added tests for changed code.
  • Updated documentation for changed code.

I don't know how to test or document this here, but i've done so at https://gist.github.com/CTimmerman/ccf884f8c8dcc284588f1811ed99be6c and that worked fine.

@neersighted
Copy link
Member

I'm not sure how to feel about this overall -- it adds another layer of complexity and potential frustration (see: transient PyPI connection issues/poisoned caches).

If this was better abstracted/less brittle-looking, and had robust tests, I think it might have a shot. The present design just seems like another layer of potential network breakage, so I'm going to close this for now but remain open to a revised design.

@CTimmerman
Copy link
Author

Whoa, excuse me for not having fixed this last Sunday. It's intentionally simple but maybe i can find and adapt an existing poetry test next week.

@CTimmerman
Copy link
Author

Then again, i'll just use my own resume script or wget and pip as those are already available, without adding poetry as additional complexity.

@neersighted
Copy link
Member

Whoa, excuse me for not having fixed this last Sunday. It's intentionally simple but maybe i can find and adapt an existing poetry test next week.

I don't mean to try to turn you off contributing at all -- the PR was merely a year old with merge conflicts and unlikely to make it in the present state. If you feel you can make the change robust and testable, please do feel free to submit the change.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resume interrupted downloads
2 participants