Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command catch KeyboardInterrupt and restore original_content (2933, 318) #3233

Merged
merged 6 commits into from
Oct 19, 2020

Conversation

estyxx
Copy link
Member

@estyxx estyxx commented Oct 17, 2020

Pull Request Check List

Resolves: #2933 #318

  • Added tests for changed code.
  • Updated documentation for changed code.

I wrapped KeyboardInterrupt where we are changing the content and write it...
At line 103 I also write original_content instead of content, because if there isn't any package to add I will expect that nothing change... let me know if I'm wrong...

FYI this issue is related to Hacktoberfest

@estyxx estyxx mentioned this pull request Oct 18, 2020
3 tasks
@estyxx estyxx changed the title Wrap KeyboardInterrupt and restore original_content Add command catch KeyboardInterrupt and restore original_content (2933, 318) Oct 18, 2020
@estyxx estyxx marked this pull request as ready for review October 18, 2020 15:55
@finswimmer finswimmer requested a review from a team October 19, 2020 19:16
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments.

poetry/console/commands/add.py Outdated Show resolved Hide resolved
poetry/console/commands/add.py Show resolved Hide resolved
poetry/console/commands/add.py Outdated Show resolved Hide resolved
@estyxx estyxx requested a review from abn October 19, 2020 21:38
Update comment

Co-authored-by: Arun Babu Neelicattu <[email protected]>
@abn abn merged commit a66033b into python-poetry:master Oct 19, 2020
@abn
Copy link
Member

abn commented Oct 19, 2020

@estyxx thank you for your contributions!

@estyxx estyxx deleted the issue/2933 branch October 19, 2020 21:56
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl-C during poetry add doesn't revert changes
3 participants