Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds @generated to header of lockfile #2773

Merged
merged 10 commits into from
Sep 18, 2022

Conversation

vishalkuo
Copy link
Contributor

@vishalkuo vishalkuo commented Aug 5, 2020

Pull Request Check List

Resolves: #2034

It's useful to both developer tools and for users to recognize the lockfile is generated. This header should achieve both

  • Added tests for changed code.
  • Updated documentation for changed code. (Not sure if applicable)

@finswimmer finswimmer added the kind/feature Feature requests/implementations label Aug 6, 2020
@finswimmer finswimmer requested a review from a team August 6, 2020 04:54
@Secrus
Copy link
Member

Secrus commented May 21, 2022

Hi, are you still interested in contributing this to Poetry? If so, please merge the master branch and fix conflicts. This would allow for a review to be done.

@vishalkuo
Copy link
Contributor Author

Rebased, please take a look

@Secrus Secrus requested a review from a team May 22, 2022 21:48
src/poetry/packages/locker.py Outdated Show resolved Hide resolved
neersighted
neersighted previously approved these changes Jun 21, 2022
@vishalkuo
Copy link
Contributor Author

hi, any updates on this?

@neersighted neersighted added the impact/changelog Requires a changelog entry label Sep 18, 2022
@neersighted neersighted added this to the 1.3 milestone Sep 18, 2022
@neersighted neersighted merged commit 3b4ac37 into python-poetry:master Sep 18, 2022
@marcorichetta
Copy link

marcorichetta commented Dec 15, 2022

Hi! I had to do some digging to find out which version of poetry a lockfile was generated with.

Is there a possibility to add the Poetry version in lockfile metadata?

Related: #6763

Thanks!

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/changelog Requires a changelog entry kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @generated to poetry.lock for Phabricator support
6 participants