Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation permissions #146

Closed
wants to merge 2 commits into from
Closed

Fix installation permissions #146

wants to merge 2 commits into from

Conversation

Victor-Savu
Copy link

@Victor-Savu Victor-Savu commented May 27, 2018

Avoid having to use superuser (administrator) privileges for platforms where the global pip installation directory is not writable by the regular user.

Se pip help install | grep -A 4 -e '--user':

  --user                      Install to the Python user install directory for
                              your platform. Typically ~/.local/, or
                              %APPDATA%\Python on Windows. (See the Python
                              documentation for site.USER_BASE for full
                              details.)

Docs for site.USER_BASE.

Fixes:

Open questions:

  • Should this be optional? If so, should it be opt-in, or opt-out?
  • Should we prompt the user that the user install directory (site.USER_BASE) needs to be in the $PATH / %PATH% variable in order for poetry to be recognized as a command?

Avoid having to use superuser (administrator) privileges for platforms where the global pip installation directory is not writable by the regular user.
@Victor-Savu Victor-Savu changed the title Install to the user install directory Fix installation permissions May 31, 2018
@cauebs
Copy link
Contributor

cauebs commented Jun 1, 2018

It appears to have worked.

~ $  curl -sSL https://raw.githubusercontent.com/Victor-Savu/poetry/patch-1/get-poetry.py | python
Retrieving metadata

Installing version: 0.10.2
  - Getting dependencies
  - Vendorizing dependencies
  - Installing poetry

poetry (0.10.2) successfully installed!
~ $ poetry --version
Poetry 0.10.2

@jgirardet
Copy link
Contributor

I proposed sudo in #163
but I agree --user is better

@Victor-Savu
Copy link
Author

Victor-Savu commented Jun 2, 2018

@jgirardet To be honest, I am a bit worried by the idea that different packages live in different places :) However, I would like this to work for people who either don't have the privilege of sudo, or who simply don't feel like they want to bestow their software unto all the users of the system.

@Victor-Savu
Copy link
Author

@sdispater Do you have any suggestions or preference regarding the two open questions in this PR?

@ranisalt
Copy link

ranisalt commented Jul 8, 2018

The README instructions are broken because of this missing flag, yet it does not seem to be priority.

@sdispater
Copy link
Member

Closing since with with the new installer permissions error should no longer exist.

@sdispater sdispater closed this Oct 25, 2018
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants