-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multiple file hashing methods for backwards and forwards compatibility #4578
Comments
I'm going to undertake this! |
python-poetry/poetry-core@68bf052 implemented a key part of this and I think @sdispater is heading in a similar direction… |
python-poetry/poetry-core@68bf052 is not yet in 1.0 branch nor is it in a 1.1.0 alpha release. I'm not sure of the best way to consume |
This in in progress in #4486. |
This allows for much-improved compatibility when interfacing with legacy PyPI-compatible repositories. This is a successor PR to #4866, and closes #4578 and #4085. Co-authored-by: Andreas Stenius <[email protected]>
This allows for much-improved compatibility when interfacing with legacy PyPI-compatible repositories. This is a successor PR to #4486, and closes #4578 and #4085. Co-authored-by: Andreas Stenius <[email protected]>
Thank you all especially @GMouzourou for picking up where I left off and finishing this finally! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Issue
My PR #4573 improves where the hash of an archive is checked against the hashes in the lockfile. While working on that PR, I spotted a potential improvement but want to collect feedback before I implement it.
I think this area could be further improved by representing the hashes as a
dataclass
or something containing the hash type and the string digest. The types of hashes would be more robust then instead of hardcoding sha256 inpoetry/installation/executor.py
and inFileDependency.hash()
. It would also enable enumeration of hash types of known hashes so thatFileDependency.hash()
could return a list of hashes based on requested types. Doing this might alleviate the md5/sha256 problems arising from changes in poetry-core 1.0.6+ that affect Poetry 1.1.7+ users using Artifactory in at least #4523.I'm willing to undertake this implementation if no maintainers object.
The text was updated successfully, but these errors were encountered: