Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error message on malformed authors is not helpful #2592

Closed
3 tasks done
seansfkelley opened this issue Jun 24, 2020 · 3 comments
Closed
3 tasks done

error message on malformed authors is not helpful #2592

seansfkelley opened this issue Jun 24, 2020 · 3 comments
Labels
area/error-handling Bad error messages/insufficient error handling status/duplicate Duplicate issues

Comments

@seansfkelley
Copy link

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: macOS Mojave
  • Poetry version: 1.0.5
  • Link of a Gist with the contents of your pyproject.toml file: see below
[tool.poetry]
name = "docs"
version = "0.1.0"
description = ""
authors = ["[email protected]"]

Issue

When trying to install with the above project configuration, I get something like:

$ poetry install
Installing dependencies from lock file

No dependencies to install or update


[AttributeError]
'NoneType' object has no attribute 'group'

As noted in #2263, Poetry expects the format author <email>. That's fine, but I had to run poetry install -v and read the implementation to realize that the problem was with the authors field. I won't try argue that it should accept plain emails here (though I personally think it should), but it definitely should try to be a bit more helpful with the messaging.

@seansfkelley seansfkelley added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jun 24, 2020
@finswimmer
Copy link
Member

Hello @seansfkelley,

thanks for reporting and giving feedback 👍 However, this was reported already earlier in #1143 and a solution is in progress (#1935).

fin swimmer

@finswimmer finswimmer added status/duplicate Duplicate issues area/error-handling Bad error messages/insufficient error handling and removed kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jun 25, 2020
@seansfkelley
Copy link
Author

seansfkelley commented Jun 25, 2020 via email

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/error-handling Bad error messages/insufficient error handling status/duplicate Duplicate issues
Projects
None yet
Development

No branches or pull requests

2 participants