-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Raise a ValueError when author name has invalid
- Loading branch information
1 parent
808fd81
commit 6a0ac4a
Showing
2 changed files
with
13 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -163,11 +163,10 @@ def _get_author(self): # type: () -> dict | |
m = AUTHOR_REGEX.match(self._authors[0]) | ||
|
||
if m is None: | ||
logger.warning( | ||
raise ValueError( | ||
"Invalid author string. Must be in the format: " | ||
"John Smith <[email protected]>" | ||
) | ||
return {"name": None, "email": None} | ||
|
||
name = m.group("name") | ||
email = m.group("email") | ||
|
@@ -181,11 +180,10 @@ def _get_maintainer(self): # type: () -> dict | |
m = AUTHOR_REGEX.match(self._maintainers[0]) | ||
|
||
if m is None: | ||
logger.warning( | ||
raise ValueError( | ||
"Invalid maintainer string. Must be in the format: " | ||
"John Smith <[email protected]>" | ||
) | ||
return {"name": None, "email": None} | ||
|
||
name = m.group("name") | ||
email = m.group("email") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,9 +17,18 @@ def test_package_authors(): | |
assert package.author_name == "John Doe" | ||
assert package.author_email is None | ||
|
||
|
||
def test_package_authors_invalid(): | ||
package = Package("foo", "0.1.0") | ||
|
||
package.authors.insert(0, "<John Doe") | ||
assert package.author_name is None | ||
assert package.author_email is None | ||
with pytest.raises(ValueError) as e: | ||
package.author_name | ||
|
||
assert ( | ||
str(e.value) | ||
== "Invalid author string. Must be in the format: John Smith <[email protected]>" | ||
) | ||
|
||
|
||
@pytest.mark.parametrize("category", ["main", "dev"]) | ||
|