Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private property to configuration #27

Closed
wants to merge 1 commit into from

Conversation

utek
Copy link

@utek utek commented Apr 19, 2020

Add private property to project properties.

Required by python-poetry/poetry#2322

Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably okay to go in, but I would like to wait till we have a resolution for #26 since that introduces the config section. I am not sure that is the section name we will go with, so figured it might be a good idea to do that and this together.

@sdispater
Copy link
Member

sdispater commented Apr 23, 2020

If we go the route of tool.poetry.build (or tool.poetry.build.config) for #26, we might as well have a tool.poetry.publish (or tool.poetry.publish.config) to configure the publishing aspects of Poetry that are inherent to the project.

However, this begs the question: should it be integrated in poetry-core since the publishing part is not part of it?

@abn
Copy link
Member

abn commented Apr 23, 2020

We have a bit of duplication in core and poetry. We should probably discuss how to consolidate it such that poetry code builds on top of core. But, I agree, we should introduce publish session within poetry and not core. Unless ofcourse we move the entire configuration schema to core.

@alkasm
Copy link

alkasm commented Jul 16, 2020

#26 has been merged in but this has sat stale since. Hoping to see python-poetry/poetry#2322 merged so python-poetry/poetry#1537 can be closed out. Any updates @abn @sdispater?

@utek utek closed this Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants