Improve intersection of multi marker union #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
… of multi markers containing unions and single markers
radoering
force-pushed
the
improve-intersection-of-multi-marker-union
branch
from
7f4b1a4
to
4bb77ab
Compare
neersighted
approved these changes
Jan 25, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#4694
Improves the detection of empty markers when building the intersection of multi markers containing unions and single markers.
Therefore, if the list of markers of the intersection contains single markers and marker unions, the intersection of each marker union with each single marker is made. If the intersection is not a marker union but a single or empty marker, the resulting marker can be simplified.
I checked the new code for 100 % statement coverage. That is why the markers in the test cases may look a bit more complicated than in the examples in python-poetry/poetry#4694. (In order to test all paths it was necessary to use multi markers containing marker unions instead of just using marker unions.)