-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace requirements.txt with extras #6072
Conversation
You've suggested before that the Makefile is a lower priority, so I don't mind. See hugovk#81 I think the bigger change is removing Shall we make a note of these changes in the release notes at least? |
f3f3bea
to
c55d5d2
Compare
Yep, added to release notes in the last commit. |
Co-authored-by: Andrew Murray <[email protected]>
Using
extras_require
means we can install just those requirements needed for a given task at the same time as installing Pillow, rather using a separate command that installs the whole bunch.For example, to install things needed for testing:
Or for building docs:
This also removes two non-existent commands from the make help, and adds some capitalisation.
Whilst editing
Makefile
I noticedinstall-venv
is deprecated but not in the deprecations docs:Deprecated in #5171 / #5159 / Pillow 8.1.0 / 2 Jan 2021, so strictly speaking would have been eligible for removal in 9.0.0 / Jan 2022.
But this is arguably a dev helper rather than a formal API. Shall we wait for Pillow 10 (and add it to the deprecations docs?), or is it safe to remove it now?