-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved CVE images to pillow-depends #4929
Conversation
Would it make sense to put the test images in a subdirectory to make them easier to remove from a checked-out copy? All future CVE examples could be put in there as well. For example Lines 10 to 11 in c236740
Lines 59 to 61 in c236740
|
Yeah, we could put them in a Normally we can't disclose CVE details until the fix is released and announced, but I expect we'd first put them in the main repo, and only move them to the other repo after someone reports a problem with their virus scanner? Or let's keep it this way, and use a |
Fair points, I suppose these can be moved into a subdir if/when someone reports another file flagged by a virus scanner. |
python-pillow/pillow-depends#32 is merged, and CIs restarted here. |
Thank you! |
Resolves #4730. Alternative to #4869
The Pillow test suite contains several images to trigger past CVEs, for the purpose of ensuring that they do not recur. However, as the issue describes, antivirus software is not aware that Pillow is up-to-date and so these are no longer vulnerabilities.
This PR is part of moving those images to pillow-depends. python-pillow/pillow-depends#32 is the other part, and this PR fails without it.
This PR also changes the test so that it is run as part of the test suite, but skips the test if run locally without the test images.