-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reading TIFFs with PlanarConfiguration=2 #4641
Conversation
Thanks @radarhere for lint fixes. Not sure what's going on with MacOS builds and why they are failing. I don't have Mac in possession to test it first hand, so I tried enabling |
I've created PR kkopachev#2 to resolve the macOS exception |
@radarhere Thank you for update, looks cleaner. I was trying to use higher-level language approach to swap pointer :) |
No insights. If it was a simple mistake, then you would think it would be failing for more platforms than just macOS. I just found that |
I want to review this before merge for safety. Not that I’ll catch everything but I want to make a pass on it. |
0e8afd8
to
848fbfc
Compare
I've added tests for new unpackers. Travis failure is unrelated. |
Any updates here? Would love this to make it into release. |
@wiredfool Do you think you'll have time to check this before release day? |
Apparently not. It was on my list for last weekend, but I didn’t get to it. |
Hey guys, any updates here? |
@imfantuan Needs a rebase at least |
b462924
to
3569b2f
Compare
3569b2f
to
f566c8a
Compare
Rebased. |
This has major conflicts with a patch for a CVE that will be released in the next version. |
See #5178 |
Rebased in #5178. |
Fixes #4621 .
Adding support for reading of compressed TIFFs with planar config = separate.
Since TIFF reading is done in tiles or strips (might be multiple rows), I've added reading it by sample and shuffling into image data. For 16bit images I had to create new single channel unpackers.
There is also special handling for RGBa images with separate plane storage, since unpacking it sample by sample would leave data in RGBa, so there is extra step required to convert it to RGBA.
I also thought of using line-interleaved unpackers, but they seem to be no use since tiles smaller than width of image.