-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPy3 on AppVeyor #4082
PyPy3 on AppVeyor #4082
Conversation
Thanks for this! I'm cautious about using a nightly build, in case pre-release PyPy bugs fail the build. It'd be annoying for that to happen after an hour! If certain tests are failing on a given PyPy3 version, we can add a conditional |
Note that I've created PR #4083 as an alternative fix for https://bitbucket.org/pypy/pypy/issues/3079/systemerror-in-timestrptime-with-non |
The first linked issue causes a crash in The second one is in |
See https://bitbucket.org/pypy/pypy/issues/3037/pypy36-release-schedule-new-beta-quality
Perhaps this can wait for pypy-7.2.0? |
Yeah, the end of September would be good timing, we're removing PyPy2 after the 1st October release. And let's check #4083. @radarhere Any thoughts on using the nightly until the next release, or waiting until it the next PyPy release is out? |
After some thought, I'm in favour of using the nightly until the next release. It seems to me that it's helpful for the same reason why we use a dev version of Python 3.8 - to ensure that there aren't bugs when we get to the actual release. |
If you'd prefer, I can remove the last commit and put PyPy3 at the top, as I had it while working on this. |
Let's leave it where it is. If it was first, it's not obvious if a failure is from your changes or nightly. When the next official release is out, we can reconsider the position. Thank you! |
Adds PyPy3 to AppVeyor.
From #3835 (comment):
Using a nightly build due to:
PyPy3 is set to run last because this is not a stable release.