Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: 4th level menu items not showing in dark mode #5053

Closed
MarkSetchell opened this issue Nov 21, 2020 · 14 comments · Fixed by #5056
Closed

Docs: 4th level menu items not showing in dark mode #5053

MarkSetchell opened this issue Nov 21, 2020 · 14 comments · Fixed by #5056

Comments

@MarkSetchell
Copy link

The latest (coloured) documentation is completely unusable on macOS in "Dark Mode". You can't see anything in the table of contents (outlined in red in attached screen-grab)!

Screenshot 2020-11-21 at 18 21 14

@hugovk hugovk changed the title What's happened? Docs: menu not showing in dark mode Nov 21, 2020
@hugovk
Copy link
Member

hugovk commented Nov 21, 2020

What browser and OS versions are you using?

Here's how it looks for me with Chrome 86 on macOS Mojave:

image

@hugovk
Copy link
Member

hugovk commented Nov 21, 2020

Also https://pillow.readthedocs.io/en/stable/ is currently the 8.0.1 docs, but your title says 7.0.0. Please could you also empty your browser cache and reload?

@MarkSetchell
Copy link
Author

MarkSetchell commented Nov 21, 2020 via email

@hugovk
Copy link
Member

hugovk commented Nov 21, 2020

This is how it looks for me with Safari 14.0:

image

Please could you clear your browser cache and reload?

@MarkSetchell
Copy link
Author

MarkSetchell commented Nov 21, 2020 via email

@hugovk
Copy link
Member

hugovk commented Nov 21, 2020

Is it still showing 7.0.0?

image

It should be 8.0.1.

@jeremy-rifkin
Copy link

jeremy-rifkin commented Nov 24, 2020

I am running into this same issue on Firefox on Windows.
image

@hugovk
Copy link
Member

hugovk commented Nov 24, 2020

@jeremy-rifkin Please can you show what version of the docs you're on? Is it 7.0.0 or 8.0.1? The release notes page is a good place to check the latest mentioned.

https://pillow.readthedocs.io/en/stable/releasenotes/index.html

Does clearing the browser cache make any difference?

@nulano
Copy link
Contributor

nulano commented Nov 24, 2020

I also see this on 8.0.1 release notes, as well as the PR #4968 build. Clearing the cache has no effect, the 4th level of the menu is unreadable (using Vivaldi (Chromium based) on Windows). which matches all of the screenshots above.

@hugovk Try looking at https://pillow.readthedocs.io/en/stable/reference/ImageFont.html#functions directly, that should open the 4th level of the menu.

@hugovk hugovk changed the title Docs: menu not showing in dark mode Docs: 4th level menu items not showing in dark mode Nov 24, 2020
@hugovk
Copy link
Member

hugovk commented Nov 24, 2020

Thanks!

Please could you test this fix?

https://pillow--5056.org.readthedocs.build/en/5056/reference/ImageFont.html#functions

@MarkSetchell
Copy link
Author

MarkSetchell commented Nov 24, 2020 via email

@jeremy-rifkin
Copy link

@hugovk Apologies for the delayed reply. I was in 8.0.1 and cache clear made no difference.
I can confirm that the fix you just posted works on my end as well. Thank you!

@EpicWink
Copy link

EpicWink commented Dec 2, 2020

Same issue in Firefox (83.0) on Linux (Ubuntu 20.04), fixed in the link above

@hugovk
Copy link
Member

hugovk commented Dec 21, 2020

This has now been merged and will be on the stable docs site when the next release is done on 2nd January.
https://pillow.readthedocs.io/en/stable/

In the meantime, you can use the fix at the latest docs version:
https://pillow.readthedocs.io/en/latest/

Thanks all for the reports, reviews, fixes and tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants