-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to own .fold
when calling .replace()
#414
Merged
sdispater
merged 2 commits into
python-pendulum:master
from
tomage:fix-replace-after-dst-transition
Jul 10, 2020
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
import pendulum | ||
|
||
from ..conftest import assert_datetime | ||
|
||
|
||
def test_replace_tzinfo_dls_off(): | ||
utc = pendulum.datetime(2016, 3, 27, 0, 30) # 30 min before DLS turning on | ||
in_paris = utc.in_tz("Europe/Paris") | ||
|
||
assert_datetime(in_paris, 2016, 3, 27, 1, 30, 0) | ||
|
||
in_paris = in_paris.replace(second=1) | ||
|
||
assert_datetime(in_paris, 2016, 3, 27, 1, 30, 1) | ||
assert not in_paris.is_dst() | ||
assert in_paris.offset == 3600 | ||
assert in_paris.timezone_name == "Europe/Paris" | ||
|
||
|
||
def test_replace_tzinfo_dls_transitioning_on(): | ||
utc = pendulum.datetime(2016, 3, 27, 1, 30) # In middle of turning on | ||
in_paris = utc.in_tz("Europe/Paris") | ||
|
||
assert_datetime(in_paris, 2016, 3, 27, 3, 30, 0) | ||
|
||
in_paris = in_paris.replace(second=1) | ||
|
||
assert_datetime(in_paris, 2016, 3, 27, 3, 30, 1) | ||
assert in_paris.is_dst() | ||
assert in_paris.offset == 7200 | ||
assert in_paris.timezone_name == "Europe/Paris" | ||
|
||
|
||
def test_replace_tzinfo_dls_on(): | ||
utc = pendulum.datetime(2016, 10, 30, 0, 30) # 30 min before DLS turning off | ||
in_paris = utc.in_tz("Europe/Paris") | ||
|
||
assert_datetime(in_paris, 2016, 10, 30, 2, 30, 0) | ||
|
||
in_paris = in_paris.replace(second=1) | ||
|
||
assert_datetime(in_paris, 2016, 10, 30, 2, 30, 1) | ||
assert in_paris.is_dst() | ||
assert in_paris.offset == 7200 | ||
assert in_paris.timezone_name == "Europe/Paris" | ||
|
||
|
||
def test_replace_tzinfo_dls_transitioning_off(): | ||
utc = pendulum.datetime(2016, 10, 30, 1, 30) # In the middle of turning off | ||
in_paris = utc.in_tz("Europe/Paris") | ||
|
||
assert_datetime(in_paris, 2016, 10, 30, 2, 30, 0) | ||
|
||
in_paris = in_paris.replace(second=1) | ||
|
||
assert_datetime(in_paris, 2016, 10, 30, 2, 30, 1) | ||
assert not in_paris.is_dst() | ||
assert in_paris.offset == 3600 | ||
assert in_paris.timezone_name == "Europe/Paris" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why dls here and not dst?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right - I think I started off calling it "dls" (daylight-savings), but later saw that "dst" was a more common way to name it.
I'll rename to "dst".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with a fixup commit (i.e. I can squash into one commit before merge if you like, unless if you want to just squash+merge)