Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extendSelect option to flake8 plugin #559

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Susensio
Copy link
Contributor

--extend-select allows adding error codes without overriding the default --select

@ccordoba12 ccordoba12 added this to the v1.12.0 milestone May 18, 2024
@ccordoba12 ccordoba12 added the enhancement New feature or request label May 18, 2024
@ccordoba12
Copy link
Member

Hey @Susensio, thanks for your contribution! It looks good to me, but there is one thing missing.

You need to run in the root of your clone the following command:

python scripts/jsonschema2md.py pylsp/config/schema.json CONFIGURATION.md

and then commit the changes that does to CONFIGURATION.md.

That's necessary because you added a new option to the server.

@Susensio
Copy link
Contributor Author

My bad, I didn't read the docs till the end.
I've pushed a new commit with that fixed.

@ccordoba12 ccordoba12 changed the title Add extend-select to flake8 Add extendSelect to flake8 plugin Jul 24, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Susensio for your contribution!

Note: I fixed the errors reported in our Static code analysis workflow in PR #585.

@ccordoba12 ccordoba12 changed the title Add extendSelect to flake8 plugin Add extendSelect option to flake8 plugin Jul 24, 2024
@ccordoba12 ccordoba12 merged commit cf3cea1 into python-lsp:develop Jul 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants