Fix pylint hang on file with many errors #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pylint reports a large number of messages on a given file (200 should be sufficient on Linux), the returned output can exceed the maximum buffer size available to a pipe causing a deadlock as the pylint plugin waits for the pylint process to complete, while the pylint process waits for the pylint plugin to clear out the pipe. This hangs the pylint plugin and no linting is ever provided for the file. This bug only exists when the plugin lints files from the file system and is not an issue when pylsp.plugins.pylint.executable has been configured due to a different code path being used.
ccordoba12
approved these changes
May 17, 2023
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 5, 2023
## Version 1.7.4 (2023/06/29) ### Issues Closed * [Issue 393](python-lsp/python-lsp-server#393) - Environment path doesn't expand user directory In this release 1 issue was closed. ### Pull Requests Merged * [PR 394](python-lsp/python-lsp-server#394) - Resolve homedir references in Jedi environment path, by [@odiroot](https://github.com/odiroot) * [PR 381](python-lsp/python-lsp-server#381) - Report progress even when initialization fails, by [@syphar](https://github.com/syphar) * [PR 380](python-lsp/python-lsp-server#380) - Fix pylint hang on file with many errors, by [@hetmankp](https://github.com/hetmankp) In this release 3 pull requests were closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pylint reports a large number of messages on a given file (200 should be sufficient on Linux), the returned output can exceed the maximum buffer size available to a pipe causing a deadlock as the pylint plugin waits for the pylint process to complete, while the pylint process waits for the pylint plugin to clear out the pipe. This hangs the pylint plugin and no linting is ever provided for the file.
This bug only exists when the plugin lints files from the file system and is not an issue when pylsp.plugins.pylint.executable has been configured due to a different code path being used.