Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toml dependency for yapf and constrain yapf to be less than 0.32 #346

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Add toml dependency for yapf and constrain yapf to be less than 0.32 #346

merged 1 commit into from
Jan 25, 2023

Conversation

bnavigator
Copy link
Contributor

@bnavigator bnavigator commented Jan 25, 2023 •
edited by ccordoba12
Loading

Fixes #260

For the next release of yapf, the requirement has to change to tomli:
google/yapf#1040

@bnavigator bnavigator mentioned this pull request Jan 25, 2023
Merged
@ccordoba12 ccordoba12 added this to the v1.7.2 milestone Jan 25, 2023
@ccordoba12 ccordoba12 changed the title add toml to yapf <=0.32 Add toml dependency for yapf <=0.32 Jan 25, 2023
ccordoba12
ccordoba12 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnavigator!

@ccordoba12 ccordoba12 changed the title Add toml dependency for yapf <=0.32 Add toml dependency for yapf and constrain yapf to be less than 0.32 Jan 25, 2023
@ccordoba12 ccordoba12 merged commit 645d800 into python-lsp:develop Jan 25, 2023
@bnavigator bnavigator deleted the yapf-toml branch January 25, 2023 17:39
@bnavigator bnavigator mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.2
Development

Successfully merging this pull request may close these issues.

yapf formatting fails when pyproject.toml is in the workspace
2 participants
@bnavigator @ccordoba12