Make flake8 respect configuration #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Dec 12, 2022
There was a problem hiding this comment.
Thanks @delfick for your contribution! I left a small suggestion to fix our tests, otherwise looks good to me.
* ensure flake8 is run from the correct directory * make flake8 aware of the filename being linted
delfick
force-pushed
the
flake8/respect-local-config
branch
from
abe9e6b to
047af22
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was having difficulty because it seemed flake8 didn't notice my settings, so I figured out that the pylsp flake8 plugin wasn't necessarily running in the correct directory, and also was telling all the plugins the filename was 'stdin' instead of the filename of the file
This also fixes the flake8 plugin when used with https://github.com/adamchainz/flake8-no-pep420 so that it doesn't complain all the files are in an implicit namespace