Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report autoimport progress #305

Merged
merged 6 commits into from
Nov 30, 2022

Conversation

bagel897
Copy link
Contributor

Also adds rope task handle support
image
Mostly works, its hard to tell since its so fast, even on very large environments

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small style suggestions for you @bagel897, otherwise looks good to me.

pylsp/plugins/_rope_task_handle.py Show resolved Hide resolved
pylsp/plugins/rope_autoimport.py Outdated Show resolved Hide resolved
pylsp/plugins/rope_autoimport.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v1.7.0 milestone Nov 30, 2022
@ccordoba12 ccordoba12 changed the title Autoimport progress Report autoimport progress Nov 30, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks @bagel897 for your work on this!

@ccordoba12 ccordoba12 merged commit 2e98dfa into python-lsp:develop Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants