Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include class objects by default in completions #285

Merged
merged 1 commit into from
Oct 31, 2022
+5 −5
Merged

Don't include class objects by default in completions #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONFIGURATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ This server can be configured using the `workspace/didChangeConfiguration` metho
| `pylsp.plugins.jedi.environment` | `string` | Define environment for jedi.Script and Jedi.names. | `null` |
| `pylsp.plugins.jedi_completion.enabled` | `boolean` | Enable or disable the plugin. | `true` |
| `pylsp.plugins.jedi_completion.include_params` | `boolean` | Auto-completes methods and classes with tabstops for each parameter. | `true` |
| `pylsp.plugins.jedi_completion.include_class_objects` | `boolean` | Adds class objects as a separate completion item. | `true` |
| `pylsp.plugins.jedi_completion.include_function_objects` | `boolean` | Adds function objects as a separate completion item. | `true` |
| `pylsp.plugins.jedi_completion.include_class_objects` | `boolean` | Adds class objects as a separate completion item. | `false` |
| `pylsp.plugins.jedi_completion.include_function_objects` | `boolean` | Adds function objects as a separate completion item. | `false` |
| `pylsp.plugins.jedi_completion.fuzzy` | `boolean` | Enable fuzzy when requesting autocomplete. | `false` |
| `pylsp.plugins.jedi_completion.eager` | `boolean` | Resolve documentation and detail eagerly. | `false` |
| `pylsp.plugins.jedi_completion.resolve_at_most` | `integer` | How many labels and snippets (at most) should be resolved? | `25` |
Expand Down
4 changes: 2 additions & 2 deletions pylsp/config/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,12 @@
},
"pylsp.plugins.jedi_completion.include_class_objects": {
"type": "boolean",
"default": true,
"default": false,
"description": "Adds class objects as a separate completion item."
},
"pylsp.plugins.jedi_completion.include_function_objects": {
"type": "boolean",
"default": true,
"default": false,
"description": "Adds function objects as a separate completion item."
},
"pylsp.plugins.jedi_completion.fuzzy": {
Expand Down
2 changes: 1 addition & 1 deletion pylsp/plugins/jedi_completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def pylsp_completions(config, document, position):
preferred_markup_kind = _utils.choose_markup_kind(supported_markup_kinds)

should_include_params = settings.get('include_params')
should_include_class_objects = settings.get('include_class_objects', True)
should_include_class_objects = settings.get('include_class_objects', False)
should_include_function_objects = settings.get('include_function_objects', False)

max_to_resolve = settings.get('resolve_at_most', 25)
Expand Down