Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include traceback when plugin fails to load #250

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

j2kun
Copy link
Contributor

@j2kun j2kun commented Aug 6, 2022

This helped me track down google/yapf#983 (comment), and it seems like it should be the default behavior when logging is enabled.

This helped me track down google/yapf#983 (comment), and it seems like it should be the default behavior when logging is enabled.
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution @j2kun!

@ccordoba12 ccordoba12 changed the title When plugin loading fails, include stack trace. Include traceback when plugin fails to loading Aug 27, 2022
@ccordoba12 ccordoba12 added this to the v1.6.0 milestone Aug 27, 2022
@ccordoba12 ccordoba12 merged commit 98dc9c0 into python-lsp:develop Aug 27, 2022
@ccordoba12 ccordoba12 changed the title Include traceback when plugin fails to loading Include traceback when plugin fails to load Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants