-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on python-lsp-server #2
Depend on python-lsp-server #2
Conversation
Palantir's python-language-server is now unmaintained. python-lsp-server is a community-maintained fork.
requirements.txt
Outdated
python-language-server>=0.34.0 | ||
mypy | ||
future;python_version < '3' | ||
flake8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do the additional requirements come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I think they came from the old pyls-mypy branch I based my changes on (see tomv564#52). I will fix it.
mypy_ls/plugin.py
Outdated
global tmpFile | ||
tmpFile = tempfile.NamedTemporaryFile('w', delete=False) | ||
tmpFile = tempfile.NamedTemporaryFile("w", delete=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that my editor automatically blackens all Python files, I didn't mean to push these changes. I will revert them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some uniform formatting would probably be good and I did a very poor job in that regard. Therefore, this is fine with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh well I already pushed a revert. If you are OK with formatting with black I will open an issue and do it properly, with a pre-commit hook probably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be nice
README.rst
Outdated
"enabled": True, | ||
"live_mode": True, | ||
"strict": False | ||
"enabled": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my editor replacing the tabs with spaces, sorry about that.
@haplo Do you want to include any other changes in this PR? Otherwise this looks fine. |
I would keep this to the minimum to make it compatible with python-lsp-server. We can open separate issues for other changes. Feel free to squash merge. |
Palantir's python-language-server is now unmaintained. python-lsp-server is a community-maintained fork.
See tomv564#51 for a discussion.