Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multipleOf overflow #746

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Oct 4, 2020

Fixes #743, by falling back to use of Fractions on float overflow.

This passes both the required and the optional test from json-schema-org/JSON-Schema-Test-Suite#438

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #746 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          17       17           
  Lines        2664     2668    +4     
  Branches      310      310           
=======================================
+ Hits         2558     2562    +4     
  Misses         87       87           
  Partials       19       19           
Impacted Files Coverage Δ
jsonschema/tests/test_jsonschema_test_suite.py 93.02% <ø> (ø)
jsonschema/_validators.py 99.54% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58259e7...46db62a. Read the comment docs.

@Zac-HD Zac-HD force-pushed the multipleOf-overflow branch from 1436b56 to 46db62a Compare October 4, 2020 23:36
@Julian
Copy link
Member

Julian commented Oct 5, 2020

O the naïveté of our youth -- we bid you farewell...

Thanks :)!

@Julian Julian merged commit e48d56c into python-jsonschema:master Oct 5, 2020
@Zac-HD
Copy link
Member Author

Zac-HD commented Oct 5, 2020

Happy to help!

Guess I'll have to update https://hypofuzz.com/example-dashboard/failing.html, but that's OK... I might just add a link to the issue 😉

@Zac-HD Zac-HD deleted the multipleOf-overflow branch October 5, 2020 00:06
@Julian
Copy link
Member

Julian commented Oct 5, 2020

Oh. Fun. That looks nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled OverflowError when checking multipleOf with large numbers
2 participants