-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teach unbool about deeply nested objects/arrays #697
Teach unbool about deeply nested objects/arrays #697
Conversation
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 95.25% 95.22% -0.03%
==========================================
Files 18 18
Lines 2716 2703 -13
Branches 321 318 -3
==========================================
- Hits 2587 2574 -13
Misses 106 106
Partials 23 23
Continue to review full report at Codecov.
|
Now that `unbool` creates a hashable, the fallback options for `uniq` are unnecessary.
1f6d09f
to
c6f3cf7
Compare
This PR looks good to me. I have tested the following four scenarios, and all got the expected result. Code
Result
|
95fe6ca Merge pull request #694 from json-schema-org/heterogeneous-additionalItems 9c88a0b Merge pull request #697 from json-schema-org/gregsdennis/add-ref-into-known-nonapplicator fea2cf1 add tests for 2019 and 2020 6695ca3 add optional tests for `$ref`ing into known non-applicator keywords cda4281 Merge pull request #695 from json-schema-org/ether/clean-up-subSchemas 7b9f45c move subSchemas-defs.json to subSchemas.json e41ec0e remove unused definition files 349c5a8 Merge pull request #692 from json-schema-org/ether/fix-subSchemas-refs 451baca Merge pull request #670 from marksparkza/invalid-output-test b8da838 Add tests for heterogeneous arrays with additionalItems 6d7a44b fix subschema locations and their $refs ea0b63c Remove invalid output tests git-subtree-dir: json git-subtree-split: 95fe6ca20a90a019f4538f3670b6dd49d91dfdee
Fixes #686
I'm aware that TypeChecker throws a wrench into this, but I want to see if this approach seems reasonable to you before I go any farther.