Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove outdated benchmarking instructions. #690

Merged
merged 3 commits into from
May 22, 2020
Merged

WIP: Remove outdated benchmarking instructions. #690

merged 3 commits into from
May 22, 2020

Conversation

jdmoorman
Copy link
Contributor

Resolves #689

This PR removes the instructions for manually running the pyperf benchmarks from README.rst. It also fixes the tox environment (tox -e perf) for running the benchmarks, which was missing a dependency on twisted.

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0b1f80f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #690   +/-   ##
=========================================
  Coverage          ?   95.31%           
=========================================
  Files             ?       18           
  Lines             ?     2712           
  Branches          ?      321           
=========================================
  Hits              ?     2585           
  Misses            ?      104           
  Partials          ?       23           
Impacted Files Coverage Δ
jsonschema/_format.py 79.31% <0.00%> (ø)
jsonschema/validators.py 94.71% <0.00%> (ø)
jsonschema/_types.py 100.00% <0.00%> (ø)
jsonschema/cli.py 96.96% <0.00%> (ø)
jsonschema/tests/test_format.py 94.23% <0.00%> (ø)
jsonschema/tests/_suite.py 96.29% <0.00%> (ø)
jsonschema/compat.py 58.97% <0.00%> (ø)
jsonschema/tests/test_validators.py 98.57% <0.00%> (ø)
jsonschema/__init__.py 100.00% <0.00%> (ø)
jsonschema/_utils.py 94.73% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1f80f...1921d48. Read the comment docs.

tox.ini Show resolved Hide resolved
@Julian
Copy link
Member

Julian commented May 22, 2020

Merging, thanks!

@Julian Julian merged commit 5dda967 into python-jsonschema:master May 22, 2020
Julian added a commit that referenced this pull request Oct 11, 2023
a9a1e2e3 Merge pull request #690 from skryukov/add-ipv4-mask-test
69b53add Add a test case for ipv4 with netmask

git-subtree-dir: json
git-subtree-split: a9a1e2e347c3b7e840a1a2052cc7182072b23ac0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update or remove outdated benchmark instructions from README.rst.
2 participants