Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py syntax for pipenv (bug) compliancy #394

Merged
merged 4 commits into from
Mar 7, 2018
Merged

Update setup.py syntax for pipenv (bug) compliancy #394

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4553e4
update setup.py syntax for pipenv compliancy
apiraino Mar 1, 2018
8276968
fix typo
apiraino Mar 2, 2018
8ae6e6f
syntax lint fix
apiraino Mar 3, 2018
d1392e4
.
apiraino Mar 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
]

extras_require = {
"format": ["rfc3987", "strict-rfc3339", "webcolors"],
":python_version=='2.7'": ["functools32"],
"format": ["rfc3987", "strict-rfc3339", "webcolors"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we can move everything out of extra_require but I could not find in any documentation the proper syntax for this format key.

Any hint?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t think so. The format key is using extras_require as it is originally designed to do, i.e. support the package[extra] installation syntax. There are no alternatives to this feature. extras_require itself is not obsolete, only using it for environment markers is.

}

setup(
Expand All @@ -42,7 +41,10 @@
setup_requires=["setuptools_scm"],
use_scm_version=True,

install_requires=["attrs>=17.3.0", "pyrsistent>=0.14.0", "six>=1.11.0"],
install_requires=[
"attrs>=17.3.0", "pyrsistent>=0.14.0", "six>=1.11.0"
"functools32;python_version<'3'"
],
extras_require=extras_require,

packages=["jsonschema", "jsonschema.tests"],
Expand Down