Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make twisted test dep optional #639

Closed
chutz opened this issue Dec 6, 2019 · 2 comments
Closed

make twisted test dep optional #639

chutz opened this issue Dec 6, 2019 · 2 comments

Comments

@chutz
Copy link

chutz commented Dec 6, 2019

Would it be possible to make the test dep on twisted optional? I am a packager for a Linux distro, and twisted is quite a large, complicated dependency.

Running the unit tests via python -m unittest discover works perfectly without twisted. It appears that it is really just used for the FilePath object and SynchronousTestCase. These seem pretty minor, and should be relatively easy to change.

@Julian
Copy link
Member

Julian commented Dec 6, 2019

Hi. You mean for the test suite it sounds like? Twisted isn't a runtime dependency.

I'd hope any Linux distro should have Twisted packaged, it's a fairly important and also old in age library at this point, but I can certainly understand if that isn't the case for a newer distro or something -- but if you want to send a PR changing FilePath to use pathlib(2) and SynchronousTestCase to use some other implementation of assertWarns I'm happy to accept that PR, though I can't guarantee that there won't be other dependencies added, including use of other trial features if they turn out to be useful. I can say though that the plan is to stay unittest compliant yeah, so you would in theory be mostly safe with just the stdlib unittest runner.

Let me know if so and would be happy to review.

@Julian
Copy link
Member

Julian commented Dec 14, 2019

Closing this for cleanliness, but happy to review a PR if you're interested in the above.

@Julian Julian closed this as completed Dec 14, 2019
Julian added a commit that referenced this issue Mar 14, 2023
19947eaa1 test: unevaluatedProperties not affected by propertyNames
829270631 Check that large integers are multiples of small multipleOf
b59543f6e Merge pull request #647 from santhosh-tekuri/ref-start-slash
6e5d45d71 Merge pull request #646 from santhosh-tekuri/vocab-optional
0311dfda0 Merge pull request #651 from santhosh-tekuri/dynamicref-without-anchor
4503eeaf4 test: A $dynamicRef without anchor in fragment behaves identical to $ref
39af4c1ba test: $ref with absolute-path-reference
880c9933b test/vocabulary: ignore unrecognized optional vocabulary
fd80307ff Merge pull request #642 from santhosh-tekuri/time-2digit
a76ae650d Merge pull request #645 from json-schema-org/gregsdennis/add-vocab-tests-link
0e2b4eefd Merge pull request #643 from 0xSudarshan/main
2b78ccfc4 slight tweaking to wording
8716c4054 add link for vocab test suite to readme
c49ba5445 Fix an incorrect $schema identifier.
f0e5ce71e Added  test for schema-items alongside "ignored" additionalItems
76dae88ab Merge pull request #640 from santhosh-tekuri/refRemote-anchor
cb82e237c Merge pull request #641 from json-schema-org/gregsdennis/unevaluated-not-draft-next
e4afd233a test/format: hour, min, sec must be two digits
7efd51313 fix unevaluatedProperties/not tests for draft-next
e39c6ea6a test/refRemote: anchor within remote ref
bf51b32fb Merge pull request #639 from json-schema-org/additionalItems-unevaluatedItems
52160b368 Add a test for 2019's interaction between additional/unevaluatedItems
69a09a339 Fixed tests for annotation collection inside not.
e4e1a220b Draft7 if/then/else ref tests need to be wrapped in an allOf.
f5bd2f6c3 Merge pull request #632 from json-schema-org/ether/annotations-inside-not
626b433e5 test that annations are collected inside a "not"

git-subtree-dir: json
git-subtree-split: 19947eaa1289168a49edd21bb7a8aa2098069ae0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants