Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaError being raised on a valid draft-4 schema #369

Closed
vvasuki opened this issue Oct 31, 2017 · 2 comments
Closed

SchemaError being raised on a valid draft-4 schema #369

vvasuki opened this issue Oct 31, 2017 · 2 comments

Comments

@vvasuki
Copy link

vvasuki commented Oct 31, 2017

Relevant portion of the trace, along with the schema: https://pastebin.com/P69gqQLS

https://jsonschemalint.com/#/version/draft-04/markup/json confirms that the schema seen above is valid - https://i.imgur.com/0NCbT9p.png .

Confirmed on latest version by installing with: sudo pip3 install git+https://github.com/Julian/jsonschema@master -U

@Julian
Copy link
Member

Julian commented Oct 31, 2017

Hi! Thanks for the report.

What's making you think that website is any more trustworthy than jsonschema :)?

If possible, can you track down (via e.g. the context attribute or by using jsonschema.exceptions.best_match) what specifically is the claim is wrong with your schema, and we can then confirm whether that's actually a bug here or correct and a bug there?

@vvasuki
Copy link
Author

vvasuki commented Nov 1, 2017

Sorry about the false alarm - the jsonschema website is fine as well, but it seems that I was somehow checking the wrong schema (that one that shows up last in the log linked above - Turns out I was setting the type field (['properties']['publication_details']['properties']['publisher']['type']) to be this schema json.). All's well now.

@vvasuki vvasuki closed this as completed Nov 1, 2017
Julian added a commit that referenced this issue Jun 9, 2020
817b724 add perl implementation and test suite to the user list
ca14e01 Merge branch 'pull/382'
3dabf55 move non-format tests out of the format directory, while keeping all ECMA regex tests together
4121aa5 move format tests to their own directory
4bae8aa Add more idn-hostname tests to draft-2019-09 and draft-07
6d91158 [325] Add some more hostname tests
e593057 Merge pull request #389 from ssilverman/readme-drafts
fb3766d README: Improve issue/PR links
79bef22 README: Update language around drafts
ade47e4 README: Add Snow to the list of supporting Java validators
fc0c14e README: Update simple JSON example
1167669 README: Update structure, consistency, spacing, and wrapping
9514122 Merge pull request #388 from json-schema-org/ether/maxProperties=0
7646490 test that maxProperties = 0 means the object is empty
c3f4319 Merge pull request #384 from ChALkeR/chalker/unique
7766f48 Improve uniqueItems validation
7555d41 Add unnormalized $id tests
11f70eb [300] Add tests for valid use of empty fragments in "$id"
b106ff0 [299] Add tests for invalid use of fragments in "$id"
4a74d45 Fix "tilde" spelling
3eca41b Merge pull request #379 from json-schema-org/ether/remove-wrapped-refs
d61bae8 remove wrapped refs
536ec07 [359] Add unevaluatedProperties/unevaluatedItems cousin tests
ac63eb7 Small README update that introduces the concept of directories
697944e Merge pull request #374 from karenetheridge/ether/allOf-anyOf-oneOf
33f8549 test all the *Of keywords together
44b99ed Merge pull request #373 from karenetheridge/ether/items-and-contains
4a2b52f some tests of items + contains
7f00cc8 add test that was present for other drafts but not 2019-09
a3f9e2e Merge pull request #371 from karenetheridge/ether/if-then-else-boolean
aeeaecc some tests with if/then/else and boolean schemas
b8a083c Merge pull request #372 from nomnoms12/unique-false-and-zero
85728f1 Add tests for uniqueness [1] and [true]
fd01a60 Add tests for uniqueness [1] and [true]
0a8823c Merge pull request #370 from karenetheridge/ether/nul-char
fa6f4dd add tests for the NUL character in strings
8bf2f7f Merge pull request #369 from ssilverman/data-desc
2ba7a76 Add data description
4f66078 Merge pull request #367 from karenetheridge/ether/additionalItems
283da7c some more tests for additionalItems
7ba95f3 add tests for keywords maxContains, minContains
2f2e7cf Merge pull request #365 from karenetheridge/ether/move-ecma-regex
8388f27 move ECMA regex tests under format/

git-subtree-dir: json
git-subtree-split: 817b724b7a64d7c18a8232aa32b5f1cc1d6dd153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants