Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest macOS runners #268

Closed
wants to merge 1 commit into from
Closed

Add latest macOS runners #268

wants to merge 1 commit into from

Conversation

philipphofmann
Copy link

@sirosen
Copy link
Member

sirosen commented May 25, 2023

At first I thought this was an update to the github workflow for this repo, so I hit the run button.

The schema is actually vendored and sourced from SchemaStore, so this change will just be overridden.
We can use this as a thread to discuss further how you should make a change over there, but this is not going to merge.

@sirosen sirosen closed this May 25, 2023
@sirosen sirosen added the upstream-schema-issue An issue with a schema or schema provider label May 25, 2023
@philipphofmann philipphofmann deleted the add-macos-runners branch May 25, 2023 14:45
@philipphofmann
Copy link
Author

Thanks for the info @sirosen.

@philipphofmann
Copy link
Author

I opened a PR SchemaStore/schemastore#2979. Let's see how it goes.

@sirosen
Copy link
Member

sirosen commented May 25, 2023

🤞 that it goes smoothly.

There's a daily update job here which does PRs with the newly vendored schemas, so ~1 day after your changes merge, I can do a release to bundle the new schema. I generally do it when I am otherwise working on check-jsonschema or if it's been a long time, but I'm always happy to do it on-demand to get new schemas out, so feel free to ping me if you ever need it.

(I have a project to make the updates completely automated, but I haven't had time to work on it.)

@philipphofmann
Copy link
Author

Thanks for the update 👍 , @sirosen.

(I have a project to make the updates completely automated, but I haven't had time to work on it.)

I totally get that 😄.

@philipphofmann
Copy link
Author

@sirosen, the PR is merged SchemaStore/schemastore#2979. You can do a new release if you want 😃.

@sirosen
Copy link
Member

sirosen commented May 30, 2023

I've just done a release of v0.23.1 with the updated vendored schemas. Please let me know if you see any issues with it! 🙂

@philipphofmann
Copy link
Author

Thanks @sirosen 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream-schema-issue An issue with a schema or schema provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants