Handle @ characters in the userinfo section.

[tomchristie]

This PR allows handling URLs in the form https://[email protected]:[email protected]

Currently the rfc3986 package raises an InvalidAuthority exception when calling authority_info() on a URL formatted in this way. Or returns None when eg. .host/.userinfo are accessed.

Before this change...

>>> u = rfc3986.api.uri_reference("https://[email protected]:[email protected]")
>>> u.authority
'[email protected]:[email protected]'
>>> u.userinfo  # None
>>> u.host  # None

The WHATWG URL spec treats @ in the userinfo section as a non-parser terminating validation error, and URL encodes the character. https://url.spec.whatwg.org/#authority-state

After this change, we follow the WHATWG behavior, URL encoding the character if it incorrectly occurs in the userinfo...

>>> u = rfc3986.api.uri_reference("https://[email protected]:[email protected]")
>>> u.authority
'[email protected]:[email protected]'
>>> u.userinfo
'user%40gmail.com:password'
>>> u.host
'google.com'

Raised via encode/httpx#328

[sigmavirus24]

I believe you're referring to the "at sign" not ampersand. Also you're asking for auto-normalization. I believe doing:

u = rfc3986.api.uri_reference("https://[email protected]:[email protected]").normalize()

That should do what you want.

[tomchristie]

I believe you're referring to the "at sign" not ampersand.

Ug. Brain freeze moment. 🤣

Also you're asking for auto-normalization

Possibly, yes. It's not obvious to me if this "non-terminating validation error" case is the same category as normalization of valid URLs?

I believe doing [...]

The current behavior doesn't capture that behavior right now, no:

>>> rfc3986.api.uri_reference("https://[email protected]:[email protected]").normalize()
URIReference(scheme='https', authority=None, path=None, query=None, fragment=None)

If .normalize() is the right place to handle this, then I think any PR along those lines would need to handle both .uri_reference(...).normalize() and also .iri_reference(...).encode(), since...

>>> rfc3986.api.iri_reference("https://[email protected]:[email protected]").encode()
URIReference(scheme='https', authority=None, path=None, query=None, fragment=None)

[codecov-io]

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #62   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         793    795    +2     
=====================================
+ Hits          793    795    +2

Impacted Files	Coverage Δ
src/rfc3986/_mixin.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e8ffb...1d79e63. Read the comment docs.