Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TODO to reflect Py3 support in Thrift. #95

Merged
merged 1 commit into from
Jun 10, 2015
Merged

Updating TODO to reflect Py3 support in Thrift. #95

merged 1 commit into from
Jun 10, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jun 10, 2015

@wbolster FWIW I may also be willing / able to assist on #40. I was very worried that Thrift would require updating, but saw your comment and then confirmed thrift at least installs for Python 3.

Interested because we are considering building a layer around happybase for Google's newly released Cloud BigTable.

@dhermes
Copy link
Contributor Author

dhermes commented Jun 10, 2015

Looks like https://issues.apache.org/jira/browse/THRIFT-1857 is not as complete as it seemed before I finished reading all of #40.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.38% when pulling 2a71540 on dhermes:update-todo-re-py3 into 6205177 on wbolster:master.

wbolster added a commit that referenced this pull request Jun 10, 2015
Updating TODO to reflect Py3 support in Thrift.
@wbolster wbolster merged commit 8963486 into python-happybase:master Jun 10, 2015
@wbolster
Copy link
Member

Thanks merged. I've not really dived into #40; it seems Thrift had (at some point) problems with Python 3. Additionally, some code in Happybase would need some adaptation (mostly compat code for bytes/text boundaries).

@dhermes dhermes deleted the update-todo-re-py3 branch June 10, 2015 19:13
@dhermes
Copy link
Contributor Author

dhermes commented Jun 10, 2015

@wbolster As a start, #78 should be merged, or at the least the part that uses exec(open(...)) instead of execfile.

It'd be even better if exec could be ditched for something like from {NAME} import *.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants