-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #305: Add Python 3.11 support #306
Conversation
* Add GREENLET_PY311 macro * PyGreenlet structure: * Add 3 members for the "data stack": 'datastack_chunk', 'datastack_top' and 'datastack_limit'. * Add 'current_frame' member. * Rename CFrame to _PyCFrame * tox.ini: Add py311 environment. Changes partially backport from the master branch: commit 63e1099. Co-Authored-By: Miro Hrončok <[email protected]>
Sadly, creating a PR on the master branch is wrong: this PR is based on the |
FYI we are also testing this change in Fedora: https://src.fedoraproject.org/rpms/python-greenlet/pull-request/3 |
From python-greenlet/greenlet#306 Co-Authored-By: Victor Stinner <[email protected]>
@vstinner Can you please create the new PR towards new branch? We really want to see greenlet ready for py311 ASAP. |
Which new branch? https://github.com/python-greenlet/greenlet/branches |
@jamadden Can you please help with that? I guess you need to create the maintenance branch. We really need to address 3.11 building issue with greenlet in current stable ASAP, as there are lots of consumers that depends on it, notably coveragepy being one. Basically no project doing coverage can add py311 pipelines because greenlet has not stable release compatible with it. |
I'd like to see this merged also. I believe the commands to set up the 1.x branch would be... git branch 1.x 1.1.2
git push origin 1.x |
Thank you for this PR! It has been merged into |
Great! Thanks to you! |
This leak was present in the original implementation of Python 3.11 support (#306) Fixes #328 and fixes gevent/gevent#1924 ; I have run gevent's test suite locally on 3.11 with this fix without seeing any regressions.
This leak was present in the original implementation of Python 3.11 support (#306) Fixes #328 and fixes gevent/gevent#1924 ; I have run gevent's test suite locally on 3.11 with this fix without seeing any regressions.
This leak was present in the original implementation of Python 3.11 support (#306) Fixes #328 and fixes gevent/gevent#1924 ; I have run gevent's test suite locally on 3.11 with this fix without seeing any regressions.
[greenlet]'s stable release doesn't work with Python 3.11. There's a chance support will be [backported], but until either that happens or the pre-release is promoted to a stable release, the pre-release needs to be installed under 3.11. Without it, bpython can't be installed. [backported]: python-greenlet/greenlet#306 [greenlet]: python-greenlet/greenlet#295 (comment)
Support for Python 3.11 has been [backported] to the latest release of greenlet. It's no longer necessary to install a pre-release version. This reverts commit e5f7f0b. [backported]: python-greenlet/greenlet#306 (comment)
Add GREENLET_PY311 macro
PyGreenlet structure:
'datastack_top' and 'datastack_limit'.
Rename CFrame to _PyCFrame
tox.ini: Add py311 environment.
Changes partially backport from the master branch:
commit 63e1099.
Co-Authored-By: Miro Hrončok [email protected]