Remove unnecessary logging during interpreter shutdown. Fixes #426.

python-greenlet · Sep 13, 2024 · 6105b1a · 6105b1a
1 parent 8cb3791
commit 6105b1a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -8,6 +8,8 @@
 - Fix crashes on 32-bit PPC Linux.
   See `issue 422
   <https://github.com/python-greenlet/greenlet/issues/422>`_.
+- Remove unnecessary logging sometimes during interpreter shutdown.
+  See `issue 426 <https://github.com/python-greenlet/greenlet/issues/426>`_.
 
 3.1.0 (2024-09-10)
 ==================

diff --git a/src/greenlet/TThreadStateDestroy.cpp b/src/greenlet/TThreadStateDestroy.cpp
@@ -108,9 +108,13 @@ struct ThreadState_DestroyNoGIL
 #else
         if (_Py_IsFinalizing()) {
 #endif
+#ifdef GREENLET_DEBUG
+            // No need to log in the general case. Yes, we'll leak,
+            // but we're shutting down so it should be ok.
             fprintf(stderr,
                     "greenlet: WARNING: Interpreter is finalizing. Ignoring "
                     "call to Py_AddPendingCall; \n");
+#endif
             return 0;
         }
         return Py_AddPendingCall(func, arg);