This repository has been archived by the owner on May 2, 2022. It is now read-only.
Fix Pytest4.x compatibility errors #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no longer named marker attributes: pytest-dev/pytest#891 This results in not expecting param `ssl` and leads to errors like: ``` ... test/test_dugong.py::test_http_proxy[plain-None] PASSED [ 4%] test/test_dugong.py::test_http_proxy[plain-8080] PASSED [ 5%] test/test_dugong.py::test_connect_proxy[plain-None] PASSED [ 6%] test/test_dugong.py::test_connect_proxy[plain-8080] PASSED [ 7%] ... test/test_dugong.py::test_http_proxy[ssl-None] FAILED [ 51%] test/test_dugong.py::test_http_proxy[ssl-8080] FAILED [ 52%] test/test_dugong.py::test_connect_proxy[ssl-None] FAILED [ 53%] test/test_dugong.py::test_connect_proxy[ssl-8080] FAILED [ 54%] ... So, the marker `no_ssl` is just ignored. Let's use the `get_closest_marker` method instead. Signed-off-by: Stanislav Levin <[email protected]>
stanislavlevin
force-pushed
the
fix_pytest4x_compat
branch
from
c7af514
to
844136b
Compare
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no longer named marker attributes:
pytest-dev/pytest#891
This results in not expecting param
ssland leads to errors like: