Centralize error handling #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ChrisLovering
force-pushed
the
better-error-handling
branch
from
2481ae3 to
09ec24f
Compare
MarkKoz
requested changes
Mar 11, 2024
|
@MarkKoz I've pushed two commits that address your comments, I'll squash them into the main ones later. |
MarkKoz
approved these changes
Mar 12, 2024
shtlrs
force-pushed
the
better-error-handling
branch
from
39c4003 to
7d9cb68
Compare
This also moves the handle_forbidden_from_block util to the package's ctor to ensure backwards compat
this represents an interface that all command handlers will need to implement in order to be able to use them in both app & text command errors
The purpose is to register the handlers in one place, which will allow us to delegate the choosing of the right handler & handling to the manager
this subclass will be calling the error manager upon error
The manager instance needs to be bound "late" due to the bot since error handlers might need an instance of bot to work
shtlrs
force-pushed
the
better-error-handling
branch
from
7d9cb68 to
dfda554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198
This is the first implementation of all the needed abstractions for the error handling in our bots.
All the necessary details will be found in the linked issue's description.