Update get_or_fetch_channel's return type #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shtlrs
force-pushed
the
update-channel-util-signature
branch
from
3e7cb2f to
942bb2e
Compare
ChrisLovering
requested changes
Jul 10, 2023
shtlrs
force-pushed
the
update-channel-util-signature
branch
from
942bb2e to
32b8455
Compare
docs/changelog.rst
Outdated
| @@ -3,6 +3,9 @@ | |||
|
|
|||
| Changelog | |||
| ========= | |||
|
|
|||
| - :bug:`187` Fix :obj:`pydis_core.utils.channel.get_or_fetch_channel`'s return type to include :obj:`discord.abc.PrivateChannel` and :obj`discord.Thread`. | |||
There was a problem hiding this comment.
Suggested change
| - :bug:`187` Fix :obj:`pydis_core.utils.channel.get_or_fetch_channel`'s return type to include :obj:`discord.abc.PrivateChannel` and :obj`discord.Thread`. | |
| - :bug:`187` Fix :obj:`pydis_core.utils.channel.get_or_fetch_channel`'s return type to include :obj:`discord.abc.PrivateChannel` and :obj:`discord.Thread`. |
Sorry, missed this on my first comment
shtlrs
force-pushed
the
update-channel-util-signature
branch
from
32b8455 to
a4c03ec
Compare
ChrisLovering
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_or_fetch_channelutil has missing return types, namelydiscord.abc.PrivateChannelanddiscord.Thread.These are needed to ensure type hinting is correct in upstream projects.