Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added black to Pipfile and black configuration to pyrpoject.toml #1053

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

tleonhardt
Copy link
Member

Added black to Pipfile and black configuration to pyrpoject.toml

Also:

  • Updated flake8 and isort config in setup.cfg to be consistent with black
  • Simplified how flake8 is executed by invoke task
  • Simplified how flake8 is executed by GitHub Actions workflow

This PR encompasses just the configuration changes present in the much larger PR #1052 - the point is to separate the configuration changes from the auto-generated changes made by black and isort

This partially addresses #930

Also:
- Updated flake8 and isort config in setup.cfg to be consistent with black
- Simplified how flake8 is executed by invoke task
- Simplified how flake8 is executed by GitHub Actions workflow
@tleonhardt tleonhardt requested a review from anselor February 2, 2021 01:57
@tleonhardt tleonhardt self-assigned this Feb 2, 2021
@tleonhardt tleonhardt requested a review from kotfu as a code owner February 2, 2021 01:57
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #1053 (f691170) into master (918200c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1053   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files          22       22           
  Lines        4630     4630           
=======================================
  Hits         4544     4544           
  Misses         86       86           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 918200c...f691170. Read the comment docs.

@tleonhardt
Copy link
Member Author

tleonhardt commented Feb 2, 2021

FYI the way the GitHub Status API works is messed up

I may try to use this commit to perform some low-level POST hackery to clear out old appveyor and travis statuses now that we aren't using them anymore but GitHub is still waiting for their freaking last status. But nothing I tried actually worked.

@tleonhardt
Copy link
Member Author

@anselor @kmvanbrunt If neither of you object, I'm going to merge this in. It is really a preparation for the other larger PR which can allow others to experiment with the configuration for black, flake8, and isort

@anselor
Copy link
Contributor

anselor commented Feb 9, 2021

I'll try to see if I can run search across the code base to address my concerns over black and items per line

@tleonhardt tleonhardt merged commit 77d5ad3 into master Feb 9, 2021
@tleonhardt tleonhardt deleted the black_config branch February 9, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants