Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default User-Agent? #391

Closed
tobixen opened this issue Apr 13, 2024 · 1 comment · Fixed by #392
Closed

Change default User-Agent? #391

tobixen opened this issue Apr 13, 2024 · 1 comment · Fixed by #392

Comments

@tobixen
Copy link
Member

tobixen commented Apr 13, 2024

Also ref home-assistant/core#105292

The default User-Agent is set to Mozilla, I'm considering to change it to python-caldav or something like that.

The Mozilla default was set by @cyrilrbt in 2010 or earlier. Was there any reason for choosing Mozilla rather than something else? Also, could there be caldav servers out there that behaves differently dependent on the User-Agent header? Even the most innocent changes in this code has caused breakages on weird servers and inbound bug reports - and I've seen systems blocking traffic based on the User-Agent. Perhaps it's best not to jinx the default setting?

@cyrilrbt
Copy link
Member

IIRC I set it to mozilla because some service was blocking me without a user agent, so this might be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants