Improved work with translation directories #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter), removed deprecated `flask.ext.babel` in favor of `flask_babel`, added object parameters into documentation
|
Some of your proposed documentation changes have made it in. However, I won't be merging this PR, because of how it handles settings. Settings are being redone to not "poison" the app.config object, for example with |
TkTech
added a commit
that referenced
this pull request
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, due to my yesterday's frustration (sorry!), I went ahead and improved documentation a bit, aswell as added
translation_directoriesparameter to the object itself, because other defaults worked that way and directories were the only one missing.flask.ext.babelin favor offlask_babel(Deprecate flask.ext and create migration tool to flask_* pallets/flask#1135)Don't worry about being honest (harsh) in a review if you disagree with anything!