Merge pull request #219 from jpvanhal/fix-list-translations-duplicate…

…-default-locale Fix list_translations() not to return default locale twice
python-babel · Apr 3, 2023 · bde0153 · bde0153
2 parents 7510e9c + dde128c
commit bde0153
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/flask_babel/__init__.py b/flask_babel/__init__.py
@@ -197,7 +197,8 @@ def list_translations(self):
                 if any(x.endswith('.mo') for x in os.listdir(locale_dir)):
                     result.append(Locale.parse(folder))
 
-        result.append(self.default_locale)
+        if self.default_locale not in result:
+            result.append(self.default_locale)
         return result
 
     @property

diff --git a/tests/test_gettext.py b/tests/test_gettext.py
@@ -96,6 +96,16 @@ def test_list_translations():
         assert str(translations[1]) == 'de_DE'
 
 
+def test_list_translations_default_locale_exists():
+    app = flask.Flask(__name__)
+    b = babel.Babel(app, default_locale='de')
+
+    with app.app_context():
+        translations = b.list_translations()
+        assert len(translations) == 1
+        assert str(translations[0]) == 'de'
+
+
 def test_no_formatting():
     """
     Ensure we don't format strings unless a variable is passed.