-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "import_cldr: if lxml is installed, use it" #393
Revert "import_cldr: if lxml is installed, use it" #393
Conversation
Agh, @jtwang, can you do AppVeyor's panties got in a random network bunch and I can't merge this without CI passing :D |
Thank you for addressing this so quickly. If you wanted to continue using lxml you might be able to do something like: parse = lxml.etree.XMLParser(remove_comments = True).parse |
This reverts commit 9b5c7f3.
ebc05ac
to
670a84e
Compare
@akx force pushed @aronbierbaum - Thanks for poking at the problem! Since Aarni is OK with nuking his addition, I'm going to stick with removing lxml entirely in the interests for KISS. :) |
Current coverage is
|
This reverts commit 9b5c7f3.
Addresses #391, not much else to say. :) FYI @aronbierbaum