-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CLDR 46 #1145
Use CLDR 46 #1145
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
- Coverage 91.31% 91.28% -0.04%
==========================================
Files 27 27
Lines 4618 4623 +5
==========================================
+ Hits 4217 4220 +3
- Misses 401 403 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looking at the release notes,
may require changes in the importer (probably to ignore When upgrading the CLDR, I've generally run the importer with the
Could be fun to see if (some of) these are supported in some locales and add some unit formatting tests for them. The new emoji search stuff would also be nice to incorporate in some form (but that'd be a follow-up feature PR). |
I'll try to see if there's some recommendation which value should be used in case both are present.
Thanks for the tip! I'll try that :)
I'll check if there are any and try to add some tests
Agreed, but yeah probably as a separate issue, I didn't really dig into that too much yet |
The only <language type="mus">Muscogee</language>
<language type="mus" alt="official">Mvskoke</language> We already ignore languages with the I also added tests for the new units - I didn't know where to put them, so I created a new file |
Forgot to add, in the two locales I checked with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, thank you!
CLDR 46 is out now, let's upgrade.
Looking at the release notes, I don't think there's anything we need to update in babel, but another pair of eyes would be nice :)