Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'Language' header field of PO files #110

Merged
merged 1 commit into from
Aug 5, 2015
Merged

Support 'Language' header field of PO files #110

merged 1 commit into from
Aug 5, 2015

Conversation

felixonmars
Copy link
Contributor

I only adjusted the tests based on @dmbasso's branch. Let me know if anything else is needed to get this merged.

@felixonmars felixonmars changed the title fix for missing Language header fix for missing Language header (with tests) Sep 6, 2014
@sils
Copy link
Member

sils commented Aug 5, 2015

hey, the tests and the feature belong together, right? So could you squash the commits? (You can use git rebase --interactive)

Also this needs a rebase which will probably fix the tests.

Can you adjust your commit message so it explains the change and not the fix? Is there any issue? Please place a reference to the issue describing the problem. If there is no issue, could you create one?

More information about a good commit message style is available on http://coala.readthedocs.org/en/latest/Getting_Involved/Writing_Good_Commits/#how-to-write-good-commit-messages .

@felixonmars felixonmars force-pushed the master branch 5 times, most recently from 32a8858 to f052a33 Compare August 5, 2015 14:27
@felixonmars
Support 'Language' header field of PO files (python-babel#76)
3ce842b 
GNU gettext has support for the 'Language' field in header entry since
version 0.18 (May 2010). This commit adds support for the field and
addresses python-babel#76.
@felixonmars
Copy link
Contributor Author

Hi, thanks for the hint :)

I have squashed the commits and rebased to current master. Please let me know if anything is still missing, thanks!

@codecov-io
Copy link

Current coverage is 82.93%

Merging #110 into master will increase coverage by +0.01% as of 7ca606b

@@            master    #110   diff @@
======================================
  Files           21      21       
  Stmts         3770    3772     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3126    3128     +2
  Partial          0       0       
  Missed         644     644

Review entire Coverage Diff

Powered by Codecov

@sils
Copy link
Member

sils commented Aug 5, 2015

lgtm, @erickwilder can you take a short look and merge?

@felixonmars felixonmars changed the title fix for missing Language header (with tests) Support 'Language' header field of PO files Aug 5, 2015
@erickwilder
Copy link
Contributor

Looks good

erickwilder added a commit that referenced this pull request Aug 5, 2015
@erickwilder
Merge pull request #110 from felixonmars/master
56c59d5 
Support 'Language' header field of PO files
@erickwilder erickwilder merged commit 56c59d5 into python-babel:master Aug 5, 2015
@felixonmars felixonmars mentioned this pull request Aug 6, 2015
Closed
@jrfern jrfern mentioned this pull request Sep 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixonmars @sils @codecov-io @erickwilder